Hitskin.com

by Sienna July 23rd 2016, 11:13 am

Sienna

Sienna: Forumember; Posts : 93
Reputation : 6
Language : English

Post n°1

Any New Java Script removes Chatbox from Toolbar?

by Sienna July 23rd 2016, 11:13 am

Forum Version: PhpBB3
Permission Level: Founder/Administrator

Hello! Back again with another problem. Sad

I've been having an issue lately when I apply any type of JS code, it gets rid of my Chatbox in the toolbar. :-(

Here's an example:

Any New Java Script removes Chatbox from Toolbar? 588ec67dd82c5c1e7c217b809b2e2ec9

Any New Java Script removes Chatbox from Toolbar? 588ec67dd82c5c1e7c217b809b2e2ec9

The JS I was trying to implement was the mentioning system script. But it's not because of that JS specifically, it's any JS.

I do have some JS already implemented though.

Last edited by Kelso on July 25th 2016, 9:41 am; edited 1 time in total

by Ange Tuteur July 23rd 2016, 3:38 pm

Ange Tuteur

Ange Tuteur: Forumaster; Posts : 13207
Reputation : 3000
Language : English & 日本語
Location : Pennsylvania

Post n°2

Re: Any New Java Script removes Chatbox from Toolbar?

by Ange Tuteur July 23rd 2016, 3:38 pm

Hi @Kelso,

When I check your forum via the console I get a JavaScript error :
"Uncaught ReferenceError: x is not defined"

It looks to be coming from a script for voting / likes. Try editing that script and look for the character "x" at the end of it. If you find this character delete it and save the script.

If that doesn't solve the problem let me know. salut

by Sienna July 23rd 2016, 7:35 pm

Sienna

Sienna: Forumember; Posts : 93
Reputation : 6
Language : English

Post n°3

Re: Any New Java Script removes Chatbox from Toolbar?

by Sienna July 23rd 2016, 7:35 pm

@Ange Tuteur

Thank you for helping!!

Sadly, I couldn't fix the 'x' you were talking about. However, I know what code you're referring too.

Voting System Code:

Code:: $(function() { // General Configuration of the plugin var config = { position_left : false, // true for left || false for right negative_vote : false, // true for negative votes || false for positive only vote_bar : false, // display a small bar under the vote buttons // button config icon_plus : '<img src="http://i18.servimg.com/u/f18/18/21/41/30/plus10.png" alt="+"/>', icon_minus : '<img src="http://i18.servimg.com/u/f18/18/21/41/30/minus10.png" alt="-"/>', // language config title_plus : 'Like %{USERNAME}\'s post', title_minus : 'Dislike %{USERNAME}\'s post', title_like_singular : '%{VOTES} person likes %{USERNAME}\'s post', title_like_plural : '%{VOTES} people like %{USERNAME}\'s post', title_dislike_singular : '%{VOTES} person dislikes %{USERNAME}\'s post', title_dislike_plural : '%{VOTES} people dislike %{USERNAME}\'s post', title_vote_bar : '%{VOTES} people liked %{USERNAME}\'s post %{PERCENT}' }, // function bound to the onclick handler of the vote buttons submit_vote = function() { var next = this.nextSibling, // the counter next to the vote button that was clicked box = this.parentNode, bar = box.getElementsByTagName('DIV'), vote = box.getElementsByTagName('A'), mode = /eval=plus/.test(this.href) ? 1 : 0, i = 0, j = vote.length, pos, neg, percent; // submit the vote asynchronously $.get(this.href, function() { next.innerHTML = +next.innerHTML + 1; // add to the vote count next.title = next.title.replace(/(\d+)/, function(M, $1) { return +$1 + 1 }); pos = +vote[0].nextSibling.innerHTML; neg = vote[1] ? +vote[1].nextSibling.innerHTML : 0; percent = pos == 0 ? '0%' : pos == neg ? '50%' : Math.round(pos / (pos + neg) * 100) + '%'; if (bar[0]) { bar[0].style.display = ''; bar[0].firstChild.style.width = percent; box.title = box.title.replace(/\d+\/\d+/, pos + '/' + ( pos + neg )).replace(/$\d+%$/, '(' + percent + ')'); } }); // revoke voting capabilities on the post once the vote is cast for (; i < j; i++) { vote[i].href = '#'; vote[i].className = vote[i].className.replace(/fa_vote/, 'fa_voted'); vote[i].onclick = function() { return false }; } return false; }, vote = $('.vote'), i = 0, j = vote.length, version = $('.bodylinewidth')[0] ? 0 : document.getElementById('wrap') ? 1 : $('.pun')[0] ? 2 : document.getElementById('ipbwrapper') ? 3 : 'badapple', // version check // version data so we don't have to redefine these arrays during the loop vdata = { tag : ['SPAN', 'LI', 'SPAN', 'LI'][version], name : ['.name', '.postprofile dt > strong', '.username', '.popmenubutton'][version], actions : ['.post-options', '.profile-icons', '.post-options', '.posting-icons'][version], }, post, plus, minus, n_pos, n_neg, title_pos, title_neg, li, ul, bar, button, total, percent, span, pseudo, vote_bar; // startup variables for later use in the loop // prevent execution if the version cannot be determined if (version == 'badapple') { if (window.console) console.warn('This plugin is not optimized for your forum version. Please contact the support for further assistance.'); return; } for (; i < j; i++) { post = $(vote[i]).parentsUntil('.post').parent()[0]; bar = $('.vote-bar', vote[i])[0]; // vote bar button = $('.vote-button', vote[i]); // plus and minus buttons pseudo = $(vdata.name, post).text() || 'MISSING_STRING'; // username of the poster ul = $(vdata.actions, post)[0]; // post actions li = document.createElement(vdata.tag); // vote system container li.className = 'fa_reputation'; if (li.tagName == 'SPAN') li.style.display = 'inline-block'; // calculate votes if (bar) { total = +bar.title.replace(/.*?\((\d+).*/, '$1'); percent = +bar.title.replace(/.*?(\d+)%.*/, '$1'); n_pos = Math.round(total * (percent / 100)); n_neg = total - n_pos; } else { n_pos = 0; n_neg = 0; } // set up negative and positive titles with the correct grammar, votes, and usernames title_pos = (n_pos == 1 ? config.title_like_singular : config.title_like_plural).replace(/%\{USERNAME\}/g, pseudo).replace(/%\{VOTES\}/g, n_pos); title_neg = (n_neg == 1 ? config.title_dislike_singular : config.title_dislike_plural).replace(/%\{USERNAME\}/g, pseudo).replace(/%\{VOTES\}/g, n_neg); // define the vote counts li.innerHTML = '<span class="fa_count fa_positive" title="' + title_pos + '">' + n_pos + '</span>' + (config.negative_vote ? ' <span class="fa_count fa_negative" title="' + title_neg + '">' + n_neg + '</span>' : ''); span = li.getElementsByTagName('SPAN'); // get the vote count containers for use as insertion points // create positive vote button plus = document.createElement('A'); plus.href = button[0] ? button[0].firstChild.href : '#'; plus.onclick = button[0] ? submit_vote : function() { return false }; plus.className = 'fa_vote' + (button[0] ? '' : 'd') + ' fa_plus'; plus.innerHTML = config.icon_plus; plus.title = (button[0] ? config.title_plus : title_pos).replace(/%\{USERNAME\}/g, pseudo); span[0] && li.insertBefore(plus, span[0]); // create negative vote button if (config.negative_vote) { minus = document.createElement('A'); minus.href = button[1] ? button[1].firstChild.href : '#'; minus.onclick = button[1] ? submit_vote : function() { return false }; minus.className = 'fa_vote' + (button[1] ? '' : 'd') + ' fa_minus'; minus.innerHTML = config.icon_minus; minus.title = (button[1] ? config.title_minus : title_neg).replace(/%\{USERNAME\}/g, pseudo); span[1] && li.insertBefore(minus, span[1]); } // create vote bar if (config.vote_bar) { vote_bar = document.createElement('DIV'); vote_bar.className = 'fa_votebar'; vote_bar.innerHTML = '<div class="fa_votebar_inner" style="width:' + percent + '%;"></div>'; vote_bar.style.display = bar ? '' : 'none'; li.title = config.title_vote_bar.replace(/%\{USERNAME\}/, pseudo).replace(/%\{VOTES\}/, n_pos + '/' + (n_pos + n_neg)).replace(/%\{PERCENT\}/, '(' + percent + '%)'); li.appendChild(vote_bar); } // finally insert the vote system and remove the default one config.position_left ? ul.insertBefore(li, ul.firstChild) : ul.appendChild(li); vote[i].parentNode.removeChild(vote[i]); } });

I went in and tried to find a random x up and down, but it wasn't there. Then I checked all my other scripts and still, nothing. :-(

I also went into the console and saw the 'x' you were talking about, but still, never found the bugger!

by Sienna July 24th 2016, 8:38 pm

Sienna

Sienna: Forumember; Posts : 93
Reputation : 6
Language : English

Post n°4

Re: Any New Java Script removes Chatbox from Toolbar?

by Sienna July 24th 2016, 8:38 pm

Bump!

by **Ape** July 24th 2016, 9:46 pm

Ape

Ape: Administrator; Posts : 19314
Reputation : 2005
Language : fluent in dork / mumbojumbo & English haha

Post n°5

Re: Any New Java Script removes Chatbox from Toolbar?

by Ape July 24th 2016, 9:46 pm

I also looked over the code gave and could not find the X Any New Java Script removes Chatbox from Toolbar? Mouais

Any New Java Script removes Chatbox from Toolbar? Left1212

Any New Java Script removes Chatbox from Toolbar? Center11

Any New Java Script removes Chatbox from Toolbar? Right112

Any New Java Script removes Chatbox from Toolbar? Ape_b110

Any New Java Script removes Chatbox from Toolbar? Ape1010

by **SLGray** July 24th 2016, 9:51 pm

SLGray

SLGray: Administrator; Posts : 51497
Reputation : 3523
Language : English
Location : United States

Post n°6

Re: Any New Java Script removes Chatbox from Toolbar?

by SLGray July 24th 2016, 9:51 pm

These are the errors I get:

Code:: SyntaxError: missing ) after argument list /:198:127 Use of getPreventDefault() is deprecated. Use defaultPrevented instead. jquery.min.js:3:7108 Use of Mutation Events is deprecated. Use MutationObserver instead.

Any New Java Script removes Chatbox from Toolbar? Slgray10

When your topic has been solved, ensure you mark the topic solved.

Never post your email in public.

by Ange Tuteur July 25th 2016, 1:09 am

Ange Tuteur

Ange Tuteur: Forumaster; Posts : 13207
Reputation : 3000
Language : English & 日本語
Location : Pennsylvania

Post n°7

Re: Any New Java Script removes Chatbox from Toolbar?

by Ange Tuteur July 25th 2016, 1:09 am

Hey,

I checked your forum again but I'm not seeing the error related to "x" anymore. Try installing another JavaScript to see if the problem returns. If it does, let me know. salut

The other errors I see shouldn't affect JS codes management. The ones that are of concern are in files like : 99XXX.js, 10XXX.js, 20XXX.js, etc..

by Sienna July 25th 2016, 9:40 am

Sienna

Sienna: Forumember; Posts : 93
Reputation : 6
Language : English

Post n°8

Re: Any New Java Script removes Chatbox from Toolbar?

by Sienna July 25th 2016, 9:40 am

@Ange Tuteur

Come to think of it, I was really tired at the time and failed to mention that I had a JS that was blank and had an "x" in it only, nothing else.

I deleted it just to clear out my JS and kept looking for the notorious "x". I reinstalled the better Mentioning System you made (thank you for that, by the way!) and it's working perfectly now. Thank you so, so much and I'm sorry I didn't realize I found the "x" sooner. :-(

For anyone else who has the similar problem, I went in and found that I had a JavaScript made and the only content in it was the letter "x", which was prevent new JS from working.

Big thanks to Ange for the help!

Solved!