The forum of the forums

Would you like to react to this message? Create an account in a few clicks or log in to continue.
The forum of the forums
3 posters

    aggregate double-posts double-loads pages hides favicon

    DVAted
    DVAted
    DVAted
    Forumember


    Posts : 61
    Reputation : 3
    Language : English
    • Post n°1

    Solved aggregate double-posts double-loads pages hides favicon

    Post by DVAted October 26th 2015, 5:37 pm

    Technical Details


    Forum version : #phpBB2
    Position : Founder
    Concerned browser(s) : Mozilla Firefox
    Screenshot of problem : http://i.imgbox.com/AepmUT54.png
    Who the problem concerns : All members
    When the problem appeared : After applying a new script to aggregate double posts.
    Forum link : www.gunetwork.org

    Description of problem

    Hello

    So I've used the "Aggregate Double Posts" script from here:
    https://help.forumotion.com/t136448-phpbb-aggregate-double-posts

    Unfortunately, every page on my site now is double-loaded. This also has the nasty side-effect of hiding my custom favicon into the default one.

    Bothers me that this happens on Firefox and not on Chrome.

    I know I have two quick fixes - use Chrome or remove the double-post script.

    I just wanted to report the bug and hope for a third solution from one of the many great scripters here like Twisted and Ange.


    Last edited by DVAted on October 26th 2015, 8:27 pm; edited 1 time in total
    • Back to top
    Ange Tuteur
    Ange Tuteur
    Ange Tuteur
    Forumaster


    Male Posts : 13207
    Reputation : 3000
    Language : English & 日本語
    Location : Pennsylvania
    • Post n°2

    Solved Re: aggregate double-posts double-loads pages hides favicon

    Post by Ange Tuteur October 26th 2015, 6:20 pm

    Hi @DVAted,

    It looks like the script reassigns the location hash so your browser focuses on the correct post ( or edit ) after the posts have been combined. You can try replacing the script with the one below if you like :
    Code:
    $(function() {
      var c = "", a, d = 0, b = 0;
      $("tr.post").each(function() {
        var e = $("> td:first span.name", this).text();
        e != c ? (d++, b++, a = $(this), b % 2 != d % 2 && $("> td", a).add($("> td", a.next())).toggleClass("row1 row2"), c = e) : (b++, $(a).find("div.signature_div").remove(), $("> td:last", a).append($("> td:last > table ", this).addClass("doublepost").attr("id", $(this).attr("id").replace(/^p([0-9]+)$/, "$1"))), $(this).next().remove(), $(this).remove())
      });
    });
    I removed the modification of the location hash which pushed another state in the history.
    • Back to top
    DVAted
    DVAted
    DVAted
    Forumember


    Posts : 61
    Reputation : 3
    Language : English
    • Post n°3

    Solved Re: aggregate double-posts double-loads pages hides favicon

    Post by DVAted October 26th 2015, 8:27 pm

    Thank you! That fixed it! I'm so happy to have it fixed Very Happy

    Now, I would have a few more things I need some help with. Do I make individual topics for them, or do I make one master-topics for all my troubles?

    They involve (but aren't limited to):

    The real question to all of this is:
    Do I make individual topics for these issues, or a master topic?
    Many thanks, Ange, you're a legend!
    Here's a topic where I've name-dropped you quite a few times:
    http://www.gunetwork.org/t8056-halloween-site-improvements
    Thank you for everything cheers
    • Back to top
    Ange Tuteur
    Ange Tuteur
    Ange Tuteur
    Forumaster


    Male Posts : 13207
    Reputation : 3000
    Language : English & 日本語
    Location : Pennsylvania
    • Post n°4

    Solved Re: aggregate double-posts double-loads pages hides favicon

    Post by Ange Tuteur October 26th 2015, 11:28 pm

    @DVAted no problem and thanks. ^^ Yes, it would be a good idea to create separate topics for multiple problems. It keeps things organized and easier to find via searching. aggregate double-posts double-loads pages hides favicon 1f609
    • Back to top
    SLGray
    SLGray
    SLGray
    Administrator
    Administrator


    Male Posts : 51554
    Reputation : 3523
    Language : English
    Location : United States
    • Post n°5

    Solved Re: aggregate double-posts double-loads pages hides favicon

    Post by SLGray October 27th 2015, 2:00 am

    Topic solved and archived



    aggregate double-posts double-loads pages hides favicon Slgray10

    When your topic has been solved, ensure you mark the topic solved.
    Never post your email in public.
    • Back to top

      Current date/time is November 11th 2024, 4:56 pm