The forum of the forums
Would you like to react to this message? Create an account in a few clicks or log in to continue.

Spoiler button not working all of a sudden

+4
Luzz
skouliki
SLGray
Gray
8 posters

Go down

Solved Spoiler button not working all of a sudden

Post by Gray May 5th 2022, 3:27 am

Technical Details


Forum version : #ModernBB
Position : Founder
Concerned browser(s) : Mozilla Firefox, Google Chrome, Opera, Other
Who the problem concerns : All members
When the problem appeared : I noticed this problem on May 4, 2022 ~8:45 PM EDT.
Forum link : https://www.revivaldawn.com/

Description of problem

Hi there,

Users (registered and guests) seem to be having an issue on my forum at the moment that is preventing them from opening Spoiler boxes.

Normally, a spoiler box expands when you click on the header. However, we noticed today that nothing happens when you click on spoiler boxes all across the site. I have not made any changes recently to any JavaScript or CSS that could've triggered this issue (I'm the only one with access to the Admin Panel).

You can see this issue for yourself on these pages (among others):
Page 1
Page 2
Page 3

I noticed on a few other Forumotion sites that this does not seem to be an issue there (including the help site here).

Test:

I was able to replicate this issue on the following browsers:
Edge
Chrome
Firefox
Opera

Any thoughts would be much appreciated!


Last edited by Gray on May 9th 2022, 7:29 pm; edited 2 times in total
avatar
Gray
Forumember

Male Posts : 60
Reputation : 1
Language : English

View user profile http://www.theromancedawnrp.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by SLGray May 5th 2022, 3:41 am

Did you use the spoiler button in the editor?
The topic was posted in the wrong section, so I have moved it to the correct section.
Please read our forum rules:  ESF General Rules


Spoiler button not working all of a sudden Slgray10

When your topic has been solved, ensure you mark the topic solved.
Never post your email in public.
SLGray
SLGray
Administrator
Administrator

Male Posts : 50155
Reputation : 3457
Language : English
Location : United States

View user profile https://forumsclub.com/gc/128-link-directory/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Gray May 5th 2022, 3:44 am

SLGray wrote:Did you use the spoiler button in the editor?
The topic was posted in the wrong section, so I have moved it to the correct section.
Please read our forum rules:  ESF General Rules

Yes, I did. After some more troubleshooting, I realized that one of my custom scripts seems to be causing this issue (I haven't narrowed down which yet). Note that I had not made any changes to these scripts recently, so, I'm assuming recent browser updates may have broken some JavaScript that's preventing the spoiler's click event from firing.
avatar
Gray
Forumember

Male Posts : 60
Reputation : 1
Language : English

View user profile http://www.theromancedawnrp.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by SLGray May 5th 2022, 3:48 am

The spoilers on this page worked for me:  https://www.revivaldawn.com/t2212-thunder-thunder-pirates#12905


Spoiler button not working all of a sudden Slgray10

When your topic has been solved, ensure you mark the topic solved.
Never post your email in public.
SLGray
SLGray
Administrator
Administrator

Male Posts : 50155
Reputation : 3457
Language : English
Location : United States

View user profile https://forumsclub.com/gc/128-link-directory/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by SLGray May 5th 2022, 3:50 am

SLGray wrote:The spoilers on this page worked for me:  https://www.revivaldawn.com/t2212-thunder-thunder-pirates#12905
Now they are not  working.


Spoiler button not working all of a sudden Slgray10

When your topic has been solved, ensure you mark the topic solved.
Never post your email in public.
SLGray
SLGray
Administrator
Administrator

Male Posts : 50155
Reputation : 3457
Language : English
Location : United States

View user profile https://forumsclub.com/gc/128-link-directory/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Gray May 5th 2022, 3:55 am

SLGray wrote:
SLGray wrote:The spoilers on this page worked for me:  https://www.revivaldawn.com/t2212-thunder-thunder-pirates#12905
Now they are not  working.

Yes, I'm fiddling with my custom JavaScript to try and figure out what's breaking it. As mentioned before, I did not make changes to any of it recently, so, I can only imagine that recent browser updates must've broken an existing piece of code.
avatar
Gray
Forumember

Male Posts : 60
Reputation : 1
Language : English

View user profile http://www.theromancedawnrp.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by SLGray May 5th 2022, 3:59 am

So you think that a browser update is conflicting with your JavaScripts?   Firefox did just have an update (100.0).


Spoiler button not working all of a sudden Slgray10

When your topic has been solved, ensure you mark the topic solved.
Never post your email in public.
SLGray
SLGray
Administrator
Administrator

Male Posts : 50155
Reputation : 3457
Language : English
Location : United States

View user profile https://forumsclub.com/gc/128-link-directory/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by skouliki May 5th 2022, 7:46 am

hello

we had some problems yesterday can you please try to clear your browser cache and retry please

thank you
skouliki
skouliki
Manager
Manager

Female Posts : 12339
Reputation : 1519
Language : English,Greek
Location : Greece

View user profile http://iconskouliki.forumgreek.com

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Luzz May 5th 2022, 9:31 am

Hello, 

This is a problem on our side, this will be solved soon. 

Thank you for reporting, we get back soon.
Luzz
Luzz
Administrator
Administrator

Posts : 1255
Reputation : 256
Language : French, English, Russian

View user profile http://forum.forumactif.com/

skouliki likes this post

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Luzz May 5th 2022, 11:53 am

Hello,

All problems with spoiler should be solved now. Could you confirm please? Smile

Thank you,
Best regards
Luzz
Luzz
Administrator
Administrator

Posts : 1255
Reputation : 256
Language : French, English, Russian

View user profile http://forum.forumactif.com/

skouliki and TonnyKamper like this post

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Gray May 5th 2022, 3:33 pm

I had narrowed down the part of my custom JavaScript that was causing the issue.

In my JavaScript code, I do a search through the .postbody and replace the HTML, which unfortunately seems to be unbinding the click events for spoilers.
Code:
$('.postbody').each(function () {
        var posthtml = "";
        posthtml = $(this).html();
        for (var i = 0; i < spchBBCode.length; i++) {
            posthtml = posthtml.replaceAll(spchBBCode[i], spchSpan[i]);
        };
        posthtml = posthtml.replaceAll('[/npc]', '</span>');
        posthtml = posthtml.replaceAll('[/plyr]', '</span>');
        $(this).html(posthtml);
    });
Note that I have had the above code for a while and it was working fine until now.

I ended up adding the following code to my custom JS yesterday to make the spoiler boxes work temporarily:
Code:
    $(document).on('click', '.spoiler_title', function () {
        var $spoilerbox = $(this).next().children().first();
        if ($spoilerbox.attr("hidden") == "hidden") {
            $spoilerbox.removeAttr("hidden");
        } else {
            $spoilerbox.attr("hidden", "until-found");
        }
    });
If I remove this temporary code, the spoiler boxes still do not work.

Do you have any clues as to why my custom code was working before but does not work anymore?

Thanks!
avatar
Gray
Forumember

Male Posts : 60
Reputation : 1
Language : English

View user profile http://www.theromancedawnrp.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Ape May 5th 2022, 4:07 pm

Luzz wrote:Hello,

All problems with spoiler should be solved now. Could you confirm please? Smile

Thank you,
Best regards
@Gray did you read this post made by Luzz ?
Try and add your old code back and see if it works now but before trying this clear your browser cache


Spoiler button not working all of a sudden Left1212Spoiler button not working all of a sudden Center11Spoiler button not working all of a sudden Right112
Spoiler button not working all of a sudden Ape_b110
Spoiler button not working all of a sudden Keep_s10
Spoiler button not working all of a sudden Ape1010
Ape
Ape
Administrator
Administrator

Male Posts : 17642
Reputation : 1884
Language : fluent in dork / mumbojumbo & English haha

View user profile http://chatworld.forumotion.co.uk/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Gray May 5th 2022, 6:34 pm

Ape wrote:
Luzz wrote:Hello,

All problems with spoiler should be solved now. Could you confirm please? Smile

Thank you,
Best regards
@Gray did you read this post made by Luzz ?
Try and add your old code back and see if it works now but before trying this clear your browser cache

Yes, I did indeed read that post. Sorry if I was not clear in my reply. Even after the fix Luzz mentioned, spoiler tags are not working in my forum with my old code (I made sure to hard refresh and also cleared my cache). As mentioned in the previous post, I'm temporarily making them work with the following additional bit of custom JS:

Gray wrote:
Code:
    $(document).on('click', '.spoiler_title', function () {
        var $spoilerbox = $(this).next().children().first();
        if ($spoilerbox.attr("hidden") == "hidden") {
            $spoilerbox.removeAttr("hidden");
        } else {
            $spoilerbox.attr("hidden", "until-found");
        }
    });



avatar
Gray
Forumember

Male Posts : 60
Reputation : 1
Language : English

View user profile http://www.theromancedawnrp.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Ape May 5th 2022, 7:07 pm

Can i ask the code your having problems with what is it meant to do?


Spoiler button not working all of a sudden Left1212Spoiler button not working all of a sudden Center11Spoiler button not working all of a sudden Right112
Spoiler button not working all of a sudden Ape_b110
Spoiler button not working all of a sudden Keep_s10
Spoiler button not working all of a sudden Ape1010
Ape
Ape
Administrator
Administrator

Male Posts : 17642
Reputation : 1884
Language : fluent in dork / mumbojumbo & English haha

View user profile http://chatworld.forumotion.co.uk/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Juviia May 5th 2022, 7:16 pm

Hi!

we also have problems with spoilers and nothing has changed, although the problem was supposedly fixed. What should we do? Are you still fixing it?
Juviia
Juviia
New Member

Posts : 4
Reputation : 1
Language : Polish

View user profile https://www.czarodzieje.org

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Balladeer May 5th 2022, 8:12 pm

Luzz wrote:Hello,

All problems with spoiler should be solved now. Could you confirm please? Smile

Thank you,
Best regards
Hi Luzz,

I'm having the same problem with my forum. It started a couple of days ago and we haven't made any changes to scripts since. I've tried clearing cache to no avail. Link to forum with spoilers. Please help!

Many thanks,
Balladeer
avatar
Balladeer
New Member

Posts : 8
Reputation : 1
Language : English

View user profile

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Ape May 5th 2022, 10:44 pm

EDIT:

I have made a report about this we was in hope that this bug was fixed but as you are still having problems we will look in to this more tomorrow.


Spoiler button not working all of a sudden Left1212Spoiler button not working all of a sudden Center11Spoiler button not working all of a sudden Right112
Spoiler button not working all of a sudden Ape_b110
Spoiler button not working all of a sudden Keep_s10
Spoiler button not working all of a sudden Ape1010
Ape
Ape
Administrator
Administrator

Male Posts : 17642
Reputation : 1884
Language : fluent in dork / mumbojumbo & English haha

View user profile http://chatworld.forumotion.co.uk/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Luzz May 6th 2022, 2:37 pm

Hello,

Thank you for your reporting.

Normally it should be comletely solved for you now (clean the cache if necessary), as we made a rollback today.

If not, please let us know Smile We apologize for all the inconvenience caused.. :rose:
Luzz
Luzz
Administrator
Administrator

Posts : 1255
Reputation : 256
Language : French, English, Russian

View user profile http://forum.forumactif.com/

TonnyKamper and Balladeer like this post

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Balladeer May 6th 2022, 2:44 pm

Working now, thanks! Very Happy
avatar
Balladeer
New Member

Posts : 8
Reputation : 1
Language : English

View user profile

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Juviia May 6th 2022, 4:05 pm

Luzz wrote:Hello,

Thank you for your reporting.

Normally it should be comletely solved for you now (clean the cache if necessary), as we made a rollback today.

If not, please let us know Smile We apologize for all the inconvenience caused.. :rose:

Unfortunately it still isn't working for us :c i cleared cache and cookies as you said, I even tried to delete spoiler's css but it didn't help.
Here is an opened for guests topic so you can see the problem.
Juviia
Juviia
New Member

Posts : 4
Reputation : 1
Language : Polish

View user profile https://www.czarodzieje.org

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Luzz May 6th 2022, 4:30 pm

Ok, thank you @Juviia Smile,

The technician is lookig at your problem (there is some conflict with JS).

(In fact, my previous message was not really right - sorry for that, there was some misunderstanding on my side, - we did not make a rollback but something to avoid all sorts of conflicts between our update and your custom codes. So our developper is looking why it did not work for you Embarassed )

Luzz
Luzz
Administrator
Administrator

Posts : 1255
Reputation : 256
Language : French, English, Russian

View user profile http://forum.forumactif.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Luzz May 6th 2022, 5:16 pm

@Juviia ,

Sorry, finaly it is not so evident to find which of yours JS is creating a problem. We are afraid it will be not possible to find for us before the WE... And our developper cannot of coarse allow himself to make expierences with your JS and test with your codes Smile

I will have to ask you to proceed like this :

Disable please the JS on your forum and verify if it works for your spoilers. (It should Smile )

If so - reactivate and disable the js one by one, until you find the source of the problem.

Thank you!
Best regards
Luzz
Luzz
Administrator
Administrator

Posts : 1255
Reputation : 256
Language : French, English, Russian

View user profile http://forum.forumactif.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Juviia May 6th 2022, 5:23 pm

I found it! Thank you very much ♥
Juviia
Juviia
New Member

Posts : 4
Reputation : 1
Language : Polish

View user profile https://www.czarodzieje.org

Luzz likes this post

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Gray May 6th 2022, 6:22 pm

Luzz wrote: @Juviia ,

Sorry, finaly it is not so evident to find which of yours JS is creating a problem. We are afraid it will be not possible to find for us before the WE... And our developper cannot of coarse allow himself to make expierences with your JS and test with your codes Smile

I will have to ask you to proceed like this :

Disable please the JS on your forum and verify if it works for your spoilers. (It should Smile )

If so - reactivate and disable the js one by one, until you find the source of the problem.

Thank you!
Best regards

Thank you for looking into this once again!

I had already found the code that was causing the JS conflict and posted it earlier in this thread. I will post the full snippet once again in this post.

Below is the custom code I'm using. This code was working fine, and it was not breaking the spoiler boxes before the recent update from your team.
Code:

/**COLOUR DIALOGUE************************************************/
    var spchBBCode = [
        "[npc=wgov]",
        "[npc=cpol]",
        "[npc=navy]",
        "[npc=bhun]",
        "[npc=revo]",
        "[npc=pirt]",
        "[npc=misc]",
        "[plyr=wgov]",
        "[plyr=cpol]",
        "[plyr=navy]",
        "[plyr=bhun]",
        "[plyr=revo]",
        "[plyr=pirt]",
        "[plyr=misc]"
    ];

    var spchSpan = [
        '<span class="wgov">',
        '<span class="cpol">',
        '<span class="navy">',
        '<span class="bhun">',
        '<span class="revo">',
        '<span class="pirt">',
        '<span class="misc">',
        '<span class="plyr wgov">',
        '<span class="plyr cpol">',
        '<span class="plyr navy">',
        '<span class="plyr bhun">',
        '<span class="plyr revo">',
        '<span class="plyr pirt">',
        '<span class="plyr misc">'
    ];   
   
    $('.postbody').each(function () {
        var posthtml = "";
        posthtml = $(this).html();
        for (var i = 0; i < spchBBCode.length; i++) {
            posthtml = posthtml.replaceAll(spchBBCode[i], spchSpan[i]);
        };
        posthtml = posthtml.replaceAll('[/npc]', '</span>');
        posthtml = posthtml.replaceAll('[/plyr]', '</span>');
        $(this).html(posthtml);
    });

    posthtml = null;
    spchSpan = null;
    spchBBCode = null;

    /***********************************************************************/
The exact line in my above snippet that is breaking the spoiler boxes after your recent update is line 45. I believe the reason for this is that replacing the HTML is unbinding the click events on the spoiler boxes.

I'm temporarily making the spoiler boxes work by adding the following code to my custom JS:
Code:
    $(document).on('click', '.spoiler_title', function () {
        var $spoilerbox = $(this).next().children().first();
        if ($spoilerbox.attr("hidden") == "hidden") {
            $spoilerbox.removeAttr("hidden");
        } else {
            $spoilerbox.attr("hidden", "until-found");
        }
    });

I hope this helps your developer narrow down which changes caused my pre-existing custom code to break.

Thanks!
avatar
Gray
Forumember

Male Posts : 60
Reputation : 1
Language : English

View user profile http://www.theromancedawnrp.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by mremmet May 7th 2022, 1:51 pm

Hi,

We've also experienced similar issue with spoilers on our forum using script from Tips&Tricks:

https://help.forumotion.com/t144115-hide-the-sentence-last-edited-by-on-specific-or-all-messages#984268

It seems that changes in DOM HTML content through this script prevents attaching click EventListener to spoilers Sad
mremmet
mremmet
New Member

Male Posts : 4
Reputation : 1
Language : English, Polish
Location : Poland

View user profile http://erised.fairtopic.com

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Luzz May 9th 2022, 11:25 am

Hello Smile ,
@Gray @mremmet and all who still had problems with spoilers - our developper made some improvement concerning the treatement of JS,

could you please try again, with your own JS activated, if the spoilers are displayed correctly now ? And if not, could you give us the URS of the messages or topics where the problem occure ?

Thank you a lot.

Regards
Luzz
Luzz
Administrator
Administrator

Posts : 1255
Reputation : 256
Language : French, English, Russian

View user profile http://forum.forumactif.com/

Ape likes this post

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by Gray May 9th 2022, 7:28 pm

Luzz wrote:Hello Smile ,
@Gray @mremmet and all who still had problems with spoilers - our developper made some improvement concerning the treatement of JS,

could you please try again, with your own JS activated, if the spoilers are displayed correctly now ? And if not, could you give us the URS of the messages or topics where the problem occure ?

Thank you a lot.

Regards

I'm no longer experiencing this issue with my old code! The latest improvement from your developer seems to have resolved the problem. Thank you very much!
avatar
Gray
Forumember

Male Posts : 60
Reputation : 1
Language : English

View user profile http://www.theromancedawnrp.com/

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by mremmet May 9th 2022, 8:21 pm

I also confirm that issue no longer occurs on old code Smile
mremmet
mremmet
New Member

Male Posts : 4
Reputation : 1
Language : English, Polish
Location : Poland

View user profile http://erised.fairtopic.com

Back to top Go down

Solved Re: Spoiler button not working all of a sudden

Post by skouliki May 9th 2022, 9:35 pm

Problem solved & topic archived.
Please read our forum rules: ESF General Rules
skouliki
skouliki
Manager
Manager

Female Posts : 12339
Reputation : 1519
Language : English,Greek
Location : Greece

View user profile http://iconskouliki.forumgreek.com

TonnyKamper likes this post

Back to top Go down

Back to top

- Similar topics

 
Permissions in this forum:
You cannot reply to topics in this forum